fix: writing failed events #83
Merged
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 86.30% 86.33% +0.03%
==========================================
Files 83 83
Lines 3732 3733 +1
Branches 376 376
==========================================
+ Hits 3221 3223 +2
Misses 418 418
+ Partials 93 92 -1 ☔ View full report in Codecov by Sentry. |
mvarendorff2
force-pushed
the
fix/writing-failed-events
branch
from
7e5623e to
64e2512
Compare
mvarendorff2
force-pushed
the
fix/writing-failed-events
branch
from
64e2512 to
49fe1dc
Compare
Enterprize1
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that caused failed events to still be written to the EventRepository. The bug occurs when a commit fails and the UnitOfWork that was used in the failing commit is later re-used. This happens because the PublishedEventEnvelopes are not cleared on Return to the pool but only on a successful commit.